fix(grid): Proccess trailing vertical scroll updates after throttling - #17486
Draft
mddragnev wants to merge 4 commits into
Draft
fix(grid): Proccess trailing vertical scroll updates after throttling#17486mddragnev wants to merge 4 commits into
mddragnev wants to merge 4 commits into
Conversation
mddragnev
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses reported grid vertical scrolling inconsistencies by adjusting the vertical scroll notification throttling so that the final (“trailing”) scroll update is processed, and updates a hierarchical grid navigation spec to account for the now-throttled scroll behavior.
Changes:
- Update
scrollNotifythrottling configuration to process trailing scroll events. - Adjust hierarchical grid navigation test timing to wait for the throttled vertical scroll to complete before asserting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/hierarchical-grid/src/hierarchical-grid.navigation.spec.ts | Adds an animation-frame wait in the ctrl+end navigation test to account for throttled vertical scrolling. |
| projects/igniteui-angular/grids/grid/src/grid-base.directive.ts | Changes vertical scroll throttling behavior to process trailing scroll updates (and includes minor formatting-only edits). |
| switchMap(time => timer(time, this.throttleScheduler)) | ||
| ) | ||
| ), | ||
| { leading: false, trailing: true } |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (2)
projects/igniteui-angular/grids/grid/src/grid-base.directive.ts:3702
- This change modifies the vertical scroll throttling behavior (enabling trailing emissions). Please add a unit test that simulates rapid scroll events and asserts that the final scroll event is processed (i.e., the last position is applied after the throttle window). Current tests call verticalScrollHandler directly and don’t exercise the throttled scrollNotify pipeline.
{ leading: true, trailing: true }
projects/igniteui-angular/grids/grid/src/grid-base.directive.ts:113
- The import list has an extra trailing comma before the closing brace, which is inconsistent with the other imports in this file and may fail linting/format rules.
import { getCurrentI18n, getNumberFormatter, IResourceChangeEventArgs, } from 'igniteui-i18n-core';
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17484 #17432
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)